Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • A Ahad Mobile
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Terraform modules
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • holatech
  • Ahad Mobile
  • Merge requests
  • !99

fix(admin): accept users without a phone number in the users list

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Khanh Pham requested to merge fix/admin-users-null-phone into develop Oct 06, 2026
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 2

Problem

The admin Users page showed "Could not load users." because the lending house user has `phone_number = NULL` (the column is nullable). The zod schema declared `phoneNumber: z.string()`, so `unwrap` rejected the whole `/admin/users-kyc` payload.

Fix

  • `phoneNumber` is now `z.string().nullable()` in the list and detail schemas.
  • Added a test for a user without a phone number. It fails before the fix and passes after.

Review gate (Opus)

Verdict: PASS WITH SHOULD-FIX, reached in 1 round.

  • SHOULD-FIX (BE DTO `phoneNumber` should be `nullable`): deferred, because it is a backend swagger change and the admin client only regenerates once staging is redeployed. Widening `User.phoneNumber` in the entity has a larger blast radius, so it goes in a follow-up.
  • NITs (detail-schema test, `—` placeholder): skipped. A null value renders as an empty cell and does not crash.

🤖 Generated with Claude Code

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/admin-users-null-phone